Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(web-component): Set right link #3110 #3111

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

tisma95
Copy link
Contributor

@tisma95 tisma95 commented Nov 23, 2024

#3110

Description of Problem

In file src/guide/extras/web-components.md {#web-components-and-typescript} we have the breaking link GlobalComponents interface the page is not found.

https://github.com/vuejs/language-tools/blob/master/packages/vscode-vue/README.md#usage

Proposed Solution

Change the link to https://github.com/vuejs/language-tools/wiki/Global-Component-Types

Additional Information

@tisma95 tisma95 mentioned this pull request Nov 23, 2024
Copy link

netlify bot commented Nov 23, 2024

Deploy Preview for vuejs ready!

Name Link
🔨 Latest commit 231aeb4
🔍 Latest deploy log https://app.netlify.com/sites/vuejs/deploys/674183ba17e7a6000850bec2
😎 Deploy Preview https://deploy-preview-3111--vuejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@AloisSeckar AloisSeckar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed in #3110, the link has changed in Vue Language Tools

@brc-dd brc-dd merged commit d600fe1 into vuejs:main Nov 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants